[
https://issues.apache.org/jira/browse/MAPREDUCE-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naganarasimha G R updated MAPREDUCE-6256:
-----------------------------------------
Attachment: MAPREDUCE-6256.20150214-1.patch
Am i assigning this as no one had assigned and also added few more refactoring
points :
* private variables TASKLOG_PULL_TIMEOUT_KEY and DEFAULT_TASKLOG_TIMEOUT was
not used anywhere in the class
I had few more queries related to distributed cache :
* As DistributedCache class itself is deprecated (MAPREDUCE-5623), do we need
to mark all the below public methods deprecated ?
** addFileToClassPath
** addArchiveToClassPath
** getArchiveVisibilities
** checkURIs
** getFileVisibilities
* All the methods in o.a.h.mapreduce.Job.java which were only accessing
DistributedCache, do we need to mark it also deprecated ?
** setCacheFiles
** setCacheArchives
** addCacheArchive
** addCacheFile
** addCacheFile
** addFileToClassPath and addArchiveToClassPath based on above point
It seems like for MR1 compatability some of these methods are still kept. If
required to be marked as deprecated please inform.
In the wake of SCM i am under the assumption that legacy Distributed cache
should be deprecated. Correct me if my understanding wrt to the usage of
DistributedCache class is wrong
> Removed unused private methods in o.a.h.mapreduce.Job.java
> ----------------------------------------------------------
>
> Key: MAPREDUCE-6256
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6256
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Devaraj K
> Assignee: Naganarasimha G R
> Priority: Minor
> Labels: newbie
> Attachments: MAPREDUCE-6256.20150214-1.patch
>
>
> These below methods are not used any where in the code and these can be
> removed.
> {code:xml}
> private void setStatus(JobStatus status)
> private boolean shouldDownloadProfile()
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
