[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323939#comment-14323939
 ] 

Tsuyoshi OZAWA commented on MAPREDUCE-4286:
-------------------------------------------

[~devaraj.k], thank you for taking this JIRA. Looks good to me overall. 

{code}
-    try {
-      conf.set(MRConfig.FRAMEWORK_NAME, "classic");
-      conf.set(JTConfig.JT_IPC_ADDRESS, "local");
-      new Cluster(conf);
-      fail("Cluster with classic Framework name shouldnot use local JT 
address");
{code}

Should we keep testClusterWithJTClientProvider like this in addition to 
testClusterWithYarnClientProvider for backward compatibility?

{code}
  @Test
  public void testClusterWithJTClientProvider() throws Exception {
    Configuration conf = new Configuration();
    try {
      conf.set(MRConfig.FRAMEWORK_NAME, "classic");
      conf.set(JTConfig.JT_IPC_ADDRESS, "local");
      new Cluster(conf);
      fail("Cluster with classic Framework name should not use " +
          "local JT address");
    } catch (IOException e){

    }
  }
{code}

> TestClientProtocolProviderImpls passes on failure conditions also
> -----------------------------------------------------------------
>
>                 Key: MAPREDUCE-4286
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4286
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>         Attachments: MAPREDUCE-4286-1.patch, MAPREDUCE-4286.patch, 
> MAPREDUCE-4286.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to