[
https://issues.apache.org/jira/browse/MAPREDUCE-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334315#comment-14334315
]
Akira AJISAKA commented on MAPREDUCE-6264:
------------------------------------------
Thanks [~brahmareddy] for the patch. Mostly looks good to me. Nice catch for
fixing {{TestAMWebApp}}.
Two minor nits:
{code}
+ client.getParams().setIntParameter(CoreConnectionPNames.SO_TIMEOUT,
timeout).setLongParameter(ClientPNames.CONN_MANAGER_TIMEOUT, (long)timeout);
{code}
Would you render the line within 80 characters?
{code}
+ throws IOException , URISyntaxException {
{code}
Would you please remove a whitespace between "IOException" and ","?
> Remove httpclient dependency from hadoop-mapreduce-client
> ---------------------------------------------------------
>
> Key: MAPREDUCE-6264
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6264
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Reporter: Akira AJISAKA
> Assignee: Brahma Reddy Battula
> Priority: Minor
> Attachments: MAPREDUCE-6264.patch
>
>
> Sub-task of HADOOP-10105. Remove httpclient dependency from TestAMWebApp.java
> and JobEndNotifier.java.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
