[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342316#comment-14342316
 ] 

Hadoop QA commented on MAPREDUCE-6136:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12701701/MAPRED-6136.patch
  against trunk revision aa55fd3.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5232//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5232//console

This message is automatically generated.

> MRAppMaster doesn't shutdown file systems
> -----------------------------------------
>
>                 Key: MAPREDUCE-6136
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6136
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: applicationmaster
>    Affects Versions: 2.4.1, 2.6.0
>            Reporter: Noah Watkins
>            Assignee: Brahma Reddy Battula
>         Attachments: MAPRED-6136.patch
>
>
> When MRAppMaster exit it doesn't call close on its open file systems 
> instances.
> MAPREDUCE-3614 sets conf.setBoolean("fs.automatic.close", false); in 
> MRAppMaster::main and then called FileSystem.closeAll() in 
> MRAppMasterShutdownHook.
> However, MAPREDUCE-4205 removed the call to FileSystem.closeAll() 
> MRAppMasterShutdownHook but left `fs.automatic.close` set to false.
> Removing `conf.setBoolean("fs.automatic.close", false);` worked for me, but 
> it wasn't clear if this had other implications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to