[
https://issues.apache.org/jira/browse/MAPREDUCE-3914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354437#comment-14354437
]
Hadoop QA commented on MAPREDUCE-3914:
--------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12652401/MAPREDUCE-3914.patch
against trunk revision 7711049.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5276//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5276//console
This message is automatically generated.
> Mismatched free() / delete / delete [] in HadoopPipes
> -----------------------------------------------------
>
> Key: MAPREDUCE-3914
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3914
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: pipes
> Affects Versions: 0.20.205.0, 0.23.0, 1.0.0
> Environment: Based upon map reduce pipes task executed on Ubuntu 11.10
> Reporter: Charles Earl
> Attachments: MAPREDUCE-3914-branch-0.23.patch,
> MAPREDUCE-3914-branch-1.0.patch, MAPREDUCE-3914.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When running valgrind on a simple MapReduce pipes job, valgrind identifies a
> mismatched new / delete:
> ==20394== Mismatched free() / delete / delete []
> ==20394== at 0x4C27FF2: operator delete(void*) (vg_replace_malloc.c:387)
> ==20394== by 0x4328A5: HadoopPipes::runTask(HadoopPipes::Factory const&)
> (HadoopPipes.cc:1171)
> ==20394== by 0x424C33: main (ProcessRow.cpp:118)
> ==20394== Address 0x9c5b540 is 0 bytes inside a block of size 131,072 alloc'd
> ==20394== at 0x4C2864B: operator new[](unsigned long)
> (vg_replace_malloc.c:305)
> ==20394== by 0x431E5D: HadoopPipes::runTask(HadoopPipes::Factory const&)
> (HadoopPipes.cc:1121)
> ==20394== by 0x424C33: main (ProcessRow.cpp:118)
> ==20394==
> ==20394== Mismatched free() / delete / delete []
> ==20394== at 0x4C27FF2: operator delete(void*) (vg_replace_malloc.c:387)
> ==20394== by 0x4328AF: HadoopPipes::runTask(HadoopPipes::Factory const&)
> (HadoopPipes.cc:1172)
> ==20394== by 0x424C33: main (ProcessRow.cpp:118)
> ==20394== Address 0x9c7b580 is 0 bytes inside a block of size 131,072 alloc'd
> ==20394== at 0x4C2864B: operator new[](unsigned long)
> (vg_replace_malloc.c:305)
> ==20394== by 0x431E6A: HadoopPipes::runTask(HadoopPipes::Factory const&)
> (HadoopPipes.cc:1122)
> ==20394== by 0x424C33: main (ProcessRow.cpp:118)
> The new [] calls in Lines 1121 and 1122 of HadoopPipes.cc:
> bufin = new char[bufsize];
> bufout = new char[bufsize];
> should have matching delete [] calls but are instead bracketed my delete on
> lines 1171 and 1172:
> delete bufin;
> delete bufout;
> So these should be replaced by delete[]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
