[
https://issues.apache.org/jira/browse/MAPREDUCE-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366437#comment-14366437
]
Gera Shegalov commented on MAPREDUCE-6275:
------------------------------------------
Thanks Jason for a review.
Mis-formatted code was hurting my eyes and so patch appears bigger than it is
after reformatting unless you diff -w. I did not change the semantics of the
file replacement even if the existing path a directory. I am also not aware
what is the background here, and tend to agree that we should have an extra
check. Probably in a separate JIRA.
I don't think /tmp is hard coded here (if I am looking at the right file)
In o.a.h.m.lib.output.TestFileOutputCommitter
{code}
private static final Path outDir = new Path(
System.getProperty("test.build.data", "/tmp"), "output");
{code}
test.build.data is recommended even on
http://wiki.apache.org/hadoop/HowToContribute
> Race condition in FileOutputCommitter v2 for user-specified task output
> subdirs
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6275
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6275
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Siqi Li
> Assignee: Gera Shegalov
> Priority: Critical
> Attachments: MAPREDUCE-6275.002.patch, MAPREDUCE-6275.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
