[ 
https://issues.apache.org/jira/browse/MAPREDUCE-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368704#comment-14368704
 ] 

Hadoop QA commented on MAPREDUCE-579:
-------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12705537/MAPREDUCE-579.patch
  against trunk revision 93d0f4a.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-tools/hadoop-streaming.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5311//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5311//console

This message is automatically generated.

> Streaming "slowmatch" documentation
> -----------------------------------
>
>                 Key: MAPREDUCE-579
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-579
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/streaming
>    Affects Versions: 2.6.0
>            Reporter: Bo Adler
>            Assignee: Harsh J
>            Priority: Trivial
>         Attachments: MAPREDUCE-579.patch
>
>
> The documentation for the Streaming module do not include any mention of the 
> "slowmatch" parameter, which checks for CDATA sections while looking for XML 
> records.
> An important point is that "slowmatch=true" violates the principle of least 
> surprise: the "begin" and "end" parameters become regular expressions instead 
> of exact strings.  This is probably a useful feature, but should definitely 
> be noted since users will be tempted to use the XML record reader on 
> not-strictly-xml files, which may require escaping the "begin" and "end" 
> patterns.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to