[
https://issues.apache.org/jira/browse/MAPREDUCE-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14374788#comment-14374788
]
Harsh J commented on MAPREDUCE-5190:
------------------------------------
+1, change looks good to me
(http://docs.oracle.com/javase/7/docs/api/java/util/Random.html#nextInt(int))
Committing shortly. Thanks Jingguo!
> Unnecessary condition test in RandomSampler
> -------------------------------------------
>
> Key: MAPREDUCE-5190
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5190
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Affects Versions: 2.6.0
> Reporter: Jingguo Yao
> Assignee: Jingguo Yao
> Priority: Minor
> Attachments: MAPREDUCE-5190.patch
>
> Original Estimate: 20m
> Remaining Estimate: 20m
>
> In getSampe method, there is a condition test after "int ind =
> r.nextInt(numSamples);". The test is "(ind != numSamples)".
> This test is unneeded since nextInt(numSamples) will not return numSamples.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
