[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490372#comment-14490372
 ] 

Gera Shegalov commented on MAPREDUCE-6300:
------------------------------------------

I assume numeric repesentation it is done to be able to sort correctly even 
when dealing with padded vs unpadded or otherwise differently formatted strings.


There are more occurrences, it's inconsistent to fix it only in one place.  I 
am leaning to -1 to revert this patch until this is clarified.  [~jlowe]? 
{code}
$ ack --java parseHadoopID
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/TasksPage.java
47:      .append(", 'mRender': parseHadoopID }")

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTasksPage.java
80:    .append(", 'mRender': parseHadoopID }")

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AppAttemptPage.java
57:      .append(", 'mRender': parseHadoopID }]").toString();

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/AppPage.java
59:      .append(", 'mRender': parseHadoopID }")

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/AppAttemptBlock.java
161:      // ConatinerID numerical value parsed by parseHadoopID in

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/AppBlock.java
275:      // AppAttemptID numerical value parsed by parseHadoopID in

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/AppsBlock.java
127:      // AppID numerical value parsed by parseHadoopID in yarn.dt.plugins.js

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/WebPageUtils.java
48:      .append(", 'mRender': parseHadoopID }")
67:      .append(", 'mRender': parseHadoopID }")
83:      .append(", 'mRender': parseHadoopID }]").toString();

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
119:      //AppID numerical value parsed by parseHadoopID in yarn.dt.plugins.js

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
175:      // AppAttemptID numerical value parsed by parseHadoopID in

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppsBlock.java
84:      // AppID numerical value parsed by parseHadoopID in yarn.dt.plugins.js
{code}

> Task list sort by task id broken
> --------------------------------
>
>                 Key: MAPREDUCE-6300
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6300
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Siqi Li
>            Assignee: Siqi Li
>            Priority: Minor
>             Fix For: 2.8.0, 2.7.1
>
>         Attachments: MAPREDUCE-6300.v1.patch, MAPREDUCE-6300.v2.patch, 
> MAPREDUCE-6300.v3.patch, screenshot-1.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to