[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498352#comment-14498352
 ] 

Hadoop QA commented on MAPREDUCE-6319:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12725912/MAPREDUCE-6319.patch
  against trunk revision 1fa8075.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5408//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5408//console

This message is automatically generated.

> Get rid of the usage of parseHadoopAttemptID in HsTaskPage for consistency
> --------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6319
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6319
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: webapps
>            Reporter: Akira AJISAKA
>            Assignee: Brahma Reddy Battula
>            Priority: Minor
>         Attachments: MAPREDUCE-6319.patch
>
>
> Per [~jira.shegalov]'s comment in MAPREDUCE-6300:
> parseHadoopAttemptID function in yarn.plugin.dt.js is used only by HsTaskPage 
> for sorting MapReduce attempt id by numerical. On the other hand, others are 
> calling parseHadoopID function for sorting various ids (including MapReduce 
> attempt id) by string. We can get rid of parseHadoopAttemptID and replace 
> with parseHadoopID for consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to