[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500071#comment-14500071
 ] 

Junping Du commented on MAPREDUCE-6318:
---------------------------------------

May be we can add interfaces of TaskHistoryEvent and JobHistoryEvent under 
HistoryEvent, so related job/task history events can inherit from them. That 
could make logic in processEventForTimelineServer() and 
processEventForNewTimelineService() even more concisely as we can get rid of 
switch cases completely.
Hi [~rkanter], any thoughts on this?

> Refactor JobHistoryEventHandler for handling events in ATS v1 after YARN-2928 
> merge back to trunk and branch-2 
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6318
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6318
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobhistoryserver
>            Reporter: Junping Du
>            Assignee: Junping Du
>
> Per discussion in YARN-3046, we need to refactor the process flow for 
> timeline events (ATS v1) in JobHistoryEventHandler. The refactor work should 
> get happen after YARN-2928 merged into trunk and branch-2.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to