[
https://issues.apache.org/jira/browse/MAPREDUCE-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516438#comment-14516438
]
Tsuyoshi Ozawa commented on MAPREDUCE-6284:
-------------------------------------------
[~ryu_kobayashi] thank you for updating. The patch introduces breaks of
indentation. Could you check them? You can see our code conventions here:
https://wiki.apache.org/hadoop/CodeReviewChecklist
For example, following indentation should be 4 spaces instead of 8 spaces:
{code}
protected void doGet(HttpServletRequest req, HttpServletResponse resp)
- throws IOException{
+ throws ServletException, IOException {
{code}
Also, we should fix the warning by findbugs. It's caused since Charset is not
given to create InputStreamReader. Please pass Charset.forName("UTF-8") like
this:
{code}
BufferedReader reader =
new BufferedReader(new InputStreamReader(
req.getInputStream(), Charset.forName("UTF-8")));
{code}
I'll take a look at the patch more deeper after addressing these comments.
> Add a 'task attempt state' to MapReduce Application Master REST API
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-6284
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6284
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Ryu Kobayashi
> Priority: Minor
> Attachments: MAPREDUCE-6284.1.patch, MAPREDUCE-6284.1.patch,
> MAPREDUCE-6284.2.patch
>
>
> It want to 'task attempt state' on the 'App state' similarly REST API.
> GET http://<proxy http address:port>/proxy/<application
> _id>/ws/v1/mapreduce/jobs/<job_id>/tasks/<task_id>/attempts/<attempt_id>/state
> PUT http://<proxy http address:port>/proxy/<application
> _id>/ws/v1/mapreduce/jobs/<job_id>/tasks/<task_id>/attempts/<attempt_id>/state
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
