[
https://issues.apache.org/jira/browse/MAPREDUCE-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525500#comment-14525500
]
Hadoop QA commented on MAPREDUCE-5264:
--------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 6s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 39s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 48s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 49s | The applied patch generated
11 new checkstyle issues (total was 341, now 352). |
| {color:red}-1{color} | checkstyle | 1m 2s | The applied patch generated 8
new checkstyle issues (total was 17, now 25). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 43s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | mapreduce tests | 9m 27s | Tests passed in
hadoop-mapreduce-client-app. |
| {color:green}+1{color} | mapreduce tests | 5m 43s | Tests passed in
hadoop-mapreduce-client-hs. |
| | | 52m 58s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12586811/MAPREDUCE-5264.20130607.1.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6ae2a0d |
| checkstyle |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5600/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5600/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt
|
| hadoop-mapreduce-client-app test log |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5600/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
|
| hadoop-mapreduce-client-hs test log |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5600/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5600/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5600/console |
This message was automatically generated.
> FileAlreadyExistsException is assumed to be thrown by FileSystem#mkdirs or
> FileContext#mkdir in the codebase
> ------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5264
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5264
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.1.0-beta
> Reporter: Rémy SAISSY
> Attachments: MAPREDUCE-5264.20130607.1.patch
>
>
> According to https://issues.apache.org/jira/browse/HADOOP-9438,
> FileSystem#mkdirs and FileContext#mkdir do not throw
> FileAlreadyExistsException if the directory already exist.
> Some places in the mapreduce codebase assumes FileSystem#mkdirs or
> FileContext#mkdir throw FileAlreadyExistsException.
> At least the following files are concerned:
> - YarnChild.java
> - JobHistoryEverntHandler.java
> - HistoryFileManager.java
> It would be good to re-review and patch this if needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
