[
https://issues.apache.org/jira/browse/MAPREDUCE-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542977#comment-14542977
]
Zhijie Shen commented on MAPREDUCE-6337:
----------------------------------------
The patch looks good to me overall. Some minor issues:
2. Move to {{case SIMPLE_ENTITY_WRITER:}} if the following is only for
SimpleEntityWriter.
{code}
159 conf.setLong(SimpleEntityWriter.TIMELINE_SERVICE_PERFORMANCE_RUN_ID,
160 System.currentTimeMillis());
{code}
3. Move to {{case JOB_HISTORY_FILE_REPLAY_MAPPER:}}?
{code}
120 // check required arguments for mtype = 2
121 if (mapperType == JOB_HISTORY_FILE_REPLAY_MAPPER) {
122 String processingPath =
123 conf.get(JobHistoryFileReplayMapper.PROCESSING_PATH);
124 if (processingPath == null || processingPath.isEmpty()) {
125 System.out.println("processing path is missing while mtype =
2");
126 return printUsage() == 0;
127 }
128 }
{code}
> add a mode to replay MR job history files to the timeline service
> -----------------------------------------------------------------
>
> Key: MAPREDUCE-6337
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6337
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Sangjin Lee
> Assignee: Sangjin Lee
> Attachments: MAPREDUCE-6337-YARN-2928.001.patch,
> MAPREDUCE-6337-YARN-2928.002.patch, MAPREDUCE-6337-YARN-2928.003.patch
>
>
> The subtask covers the work on top of YARN-3437 to add a mode to replay MR
> job history files to the timeline service storage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
