[
https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Devaraj K updated MAPREDUCE-5708:
---------------------------------
Target Version/s: 2.8.0
Hadoop Flags: Reviewed
Thanks [~konnew88] for your contribution.
+1, patch looks good to me.
> Duplicate String.format in YarnOutputFiles.getSpillFileForWrite
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-5708
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Konstantin Weitz
> Assignee: Konstantin Weitz
> Priority: Minor
> Labels: BB2015-05-TBR
> Attachments: 0001-Removed-duplicate-String.format.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The code responsible for formatting the spill file name (namely
> _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does
> not only affect performance, but leads to the weird requirement that task
> attempt ids cannot contain _%_ characters (because these would be interpreted
> as format specifiers in the outside _String.format_ call).
> I assume this was done by mistake, as it could only be useful if task attempt
> ids contained _%n_.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)