[
https://issues.apache.org/jira/browse/MAPREDUCE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576987#comment-14576987
]
Devaraj K commented on MAPREDUCE-3384:
--------------------------------------
Thanks [~brahmareddy] for updating the patch. Here are my comments for the
patch.
1. Can you change the message here as underflow?
{code:xml}
+ if ((oldSum < 0 && tempVal < 0) && (oldSum < sum)) {
+ LOG.warn("Arithmetic overflow occurs while reducing");
+ }
{code}
2. Please mark the LOG as private.
{code:xml}
+ public static final Log LOG = LogFactory.getLog(LongSumReducer.class);
{code}
3. MAPREDUCE-3385 is also trying to address the same issue, can you also take
care of the classes listed in MAPREDUCE-3385 as part of this jira and close
MAPREDUCE-3385 as duplicate.
4. And also please fix the whitespace errors for your next patch.
> Add warning message for org.apache.hadoop.mapreduce.lib.reduce.LongSumReducer
> -----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3384
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3384
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: JiangKai
> Assignee: Brahma Reddy Battula
> Attachments: MAPREDUCE-3384-002.patch, MAPREDUCE-3384.patch
>
>
> When we call the function reduce() of LongSumReducer,the result may overflow.
> We should send a warning message to users if overflow occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
