[
https://issues.apache.org/jira/browse/MAPREDUCE-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592096#comment-14592096
]
Hadoop QA commented on MAPREDUCE-6395:
--------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 15m 29s | Findbugs (version ) appears to
be broken on trunk. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 50s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 52s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 18s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 1m 11s | The patch appears to introduce 1
new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | mapreduce tests | 9m 15s | Tests passed in
hadoop-mapreduce-client-app. |
| | | 46m 31s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-mapreduce-client-app |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12740345/MAPREDUCE-6395-003.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 1c13519 |
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5813/artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
|
| hadoop-mapreduce-client-app test log |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5813/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5813/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5813/console |
This message was automatically generated.
> Improve the commit failure messages in MRAppMaster recovery
> -----------------------------------------------------------
>
> Key: MAPREDUCE-6395
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6395
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: applicationmaster
> Affects Versions: 2.7.0
> Reporter: Gera Shegalov
> Assignee: Brahma Reddy Battula
> Labels: noob
> Attachments: MAPREDUCE-6395-002.patch, MAPREDUCE-6395-003.patch,
> MAPREDUCE-6395.patch
>
>
> There are typos, and pluralis majestatis (royal we) or user-including "we"
> messages that are confusing to the users:
> {code}
> if (commitSuccess) {
> shutDownMessage = "We crashed after successfully committing.
> Recovering.";
> forcedState = JobStateInternal.SUCCEEDED;
> } else if (commitFailure) {
> shutDownMessage = "We crashed after a commit failure.";
> forcedState = JobStateInternal.FAILED;
> } else {
> //The commit is still pending, commit error
> shutDownMessage = "We crashed durring a commit";
> forcedState = JobStateInternal.ERROR;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
