[jira] [Commented] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java

[Devaraj K (JIRA)]

    [ 
https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602774#comment-14602774
 ] 

Devaraj K commented on MAPREDUCE-2631:
--------------------------------------

Thanks [~sunilg] for the patch. Can you have a look into this failure whether 
it is related to the patch?

{code:xml}
Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.184 sec <<< 
FAILURE! - in org.apache.hadoop.mapred.pipes.TestPipeApplication
testApplication(org.apache.hadoop.mapred.pipes.TestPipeApplication)  Time 
elapsed: 1.994 sec  <<< ERROR!
java.lang.NullPointerException: null
        at 
org.apache.hadoop.mapred.pipes.BinaryProtocol$TeeOutputStream.write(BinaryProtocol.java:204)
        at 
java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
        at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
        at java.io.DataOutputStream.flush(DataOutputStream.java:123)
        at 
org.apache.hadoop.mapred.pipes.BinaryProtocol.flush(BinaryProtocol.java:349)
        at 
org.apache.hadoop.mapred.pipes.Application.abort(Application.java:217)
        at 
org.apache.hadoop.mapred.pipes.TestPipeApplication.testApplication(TestPipeApplication.java:224)
{code}

> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-2631
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.23.0
>            Reporter: Ravi Teja Ch N V
>            Assignee: Sunil G
>              Labels: BB2015-05-TBR
>         Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch, 
> MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch, 
> MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
>       flush();
>       file.close();
>       out.close();
>     }
> {code} 
> In the above code, if the file.close() throws any exception out will not be 
> closed.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)