[
https://issues.apache.org/jira/browse/MAPREDUCE-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606037#comment-14606037
]
Jason Lowe commented on MAPREDUCE-6418:
---------------------------------------
Thanks for the patch, Chang!
There's a mix of space and tabs in the patch, please only use spaces.
shutdownLogManager should not declare it throws Exception. I don't see a
reason it needs to throw at all.
Please add a comment to the body of MRApp shutdownTaskLog and
shutdownLogManager explaining why it is not doing anything so when someone
comes along later it's obvious why that was done.
> MRApp should not shutdown LogManager during shutdown
> ----------------------------------------------------
>
> Key: MAPREDUCE-6418
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6418
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Chang Li
> Assignee: Chang Li
> Attachments: MAPREDUCE-6418.1.patch
>
>
> Tests in TestRecovery.java lost their logs after recovery due to the change
> of MAPREDUCE-5694. MRApp should overwrite those changes to allow log after am
> recover to be shown.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
