[
https://issues.apache.org/jira/browse/MAPREDUCE-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628326#comment-14628326
]
Hadoop QA commented on MAPREDUCE-5865:
--------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 30s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 38s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 27s | The applied patch generated 2
new checkstyle issues (total was 16, now 15). |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 22s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 52s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | mapreduce tests | 0m 36s | Tests passed in
hadoop-mapreduce-examples. |
| | | 36m 57s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12668711/MAPREDUCE-5865.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / edcaae4 |
| checkstyle |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5887/artifact/patchprocess/diffcheckstylehadoop-mapreduce-examples.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5887/artifact/patchprocess/whitespace.txt
|
| hadoop-mapreduce-examples test log |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5887/artifact/patchprocess/testrun_hadoop-mapreduce-examples.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5887/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5887/console |
This message was automatically generated.
> RecordReader is not closed in TeraInputFormat#writePartitionFile()
> ------------------------------------------------------------------
>
> Key: MAPREDUCE-5865
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5865
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv1
> Reporter: Ted Yu
> Labels: BB2015-05-TBR
> Attachments: MAPREDUCE-5865.patch
>
>
> Here is related code:
> {code}
> RecordReader<Text, Text> reader =
> inFormat.createRecordReader(splits.get(sampleStep * idx),
> context);
> reader.initialize(splits.get(sampleStep * idx), context);
> while (reader.nextKeyValue()) {
> sampler.addKey(new Text(reader.getCurrentKey()));
> records += 1;
> if (recordsPerSample <= records) {
> break;
> }
> }
> {code}
> reader should be closed using finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
