[
https://issues.apache.org/jira/browse/MAPREDUCE-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638957#comment-14638957
]
Hadoop QA commented on MAPREDUCE-6391:
--------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 5m 26s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 37s | There were no new javac warning
messages. |
| {color:green}+1{color} | release audit | 0m 21s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 20s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | mapreduce tests | 10m 32s | Tests passed in
hadoop-mapreduce-client-nativetask. |
| | | 25m 51s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12746807/MAPREDUCE-6391.001.patch
|
| Optional Tests | javac unit |
| git revision | trunk / ee98d63 |
| hadoop-mapreduce-client-nativetask test log |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5906/artifact/patchprocess/testrun_hadoop-mapreduce-client-nativetask.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5906/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5906/console |
This message was automatically generated.
> util/Timer.cc completely misunderstands _POSIX_CPUTIME
> ------------------------------------------------------
>
> Key: MAPREDUCE-6391
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6391
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: 2.7.0
> Reporter: Alan Burlison
> Assignee: Alan Burlison
> Attachments: MAPREDUCE-6391.001.patch
>
>
> util/Timer.cc contains the following code:
> clock_gettime(_POSIX_CPUTIME, &ts);
> I'm not exactly sure what sort of time value this code is attempting to
> obtain (the process's on-CPU time perhaps?) but it is completely wrong, even
> on Linux. _POSIX_CPUTIME is a feature test macro and is *not* a valid
> parameter to clock_gettime. From the clock_gettime manpage:
> bq. The symbols _POSIX_MONOTONIC_CLOCK, _POSIX_CPUTIME, _POSIX_THREAD_CPUTIME
> indicate that CLOCK_MONOTONIC, CLOCK_PROCESS_CPUTIME_ID,
> CLOCK_THREAD_CPUTIME_ID are available
> On my Linux distro the value of _POSIX_CPUTIME is defined as 0. That
> corresponds to
> bq. #define __CLOCK_REALTIME0 0 /* obsolete; same as
> CLOCK_REALTIME */
> And CLOCK_REALTIME is
> bq. #define CLOCK_REALTIME 3 /* wall clock */
> Which I suspect is not what is required here.
> Getting cross-platform CPU time is fiddly, the following blog post has a good
> summary:
> http://nadeausoftware.com/articles/2012/03/c_c_tip_how_measure_cpu_time_benchmarking
> (code examples are CC licensed so should be no taint issues)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
