[
https://issues.apache.org/jira/browse/MAPREDUCE-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643434#comment-14643434
]
Jason Lowe commented on MAPREDUCE-6394:
---------------------------------------
Thanks for updating the patch, Ray!
In the unit tests, the implicit raw counter test should be checking if the
proto has counters rather than calling getCounters on the report. I think that
test would have passed even with the original code, since getCounters() checks
for converting raw counters. The bug I mentioned above was that setting the
raw counters and then building the proto would cause the counters to be missing
from the resulting protobuf. The test should verify that setting the raw
counters causes the counters to appear in the generated protobuf.
Another thing occurred to me: what should the behavior be when someone sets the
counters _and_ the raw counters? Arguably it should take the last setting, but
I believe currently if one sets counters and then the raw counters it will
ignore the raw counters. We probably should be calling setCounters(null) in
setRawCounters and vice-versa. Would be nice to have a test to cover these
behaviors as well.
> Speed up Task processing loop in HsTasksBlock#render()
> ------------------------------------------------------
>
> Key: MAPREDUCE-6394
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6394
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: jobhistoryserver
> Affects Versions: 2.7.0
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Labels: supportability
> Attachments: MAPREDUCE-6394.001.patch, MAPREDUCE-6394.002.patch,
> MAPREDUCE-6394.003.patch, MAPREDUCE-6394.004.patch, MAPREDUCE-6394.005.patch,
> MAPREDUCE-6394.006.patch, MAPREDUCE-6394.007.patch
>
>
> In HsTasksBlock#render(), there is a loop to create a Javascript table which
> slows down immensely on jobs with a large number of tasks (200k or more).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
