[
https://issues.apache.org/jira/browse/MAPREDUCE-6455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704183#comment-14704183
]
Hadoop QA commented on MAPREDUCE-6455:
--------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 19m 18s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 8m 18s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 12s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 41s | The applied patch generated 1
new checkstyle issues (total was 176, now 176). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 34s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests | 23m 37s | Tests failed in
hadoop-common. |
| {color:green}+1{color} | mapreduce tests | 1m 52s | Tests passed in
hadoop-mapreduce-client-core. |
| | | 71m 38s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.net.TestNetUtils |
| | hadoop.ha.TestZKFailoverController |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12751354/mr-6455.2.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 4e14f79 |
| checkstyle |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-mapreduce-client-core test log |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/console |
This message was automatically generated.
> Unable to use surefire > 2.18
> -----------------------------
>
> Key: MAPREDUCE-6455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.7.1
> Reporter: Charlie Helin
> Assignee: Charlie Helin
> Attachments: mr-6455.1.patch, mr-6455.2.patch, mr-6455.2.patch
>
>
> There are some compelling features in later version of surefire which lets
> one exclude/include tests based the content of a file, re-running of test
> case etc.
> However introduced in Surefire 2.18 is also
> https://issues.apache.org/jira/browse/SUREFIRE-649. Which changed the
> convention of null properties to empty string values (""). This only applies
> to forked tests such as the MapReduce tests and cause a couple of them to
> fail because of functionality that is directly or indirectly dependent on the
> value being null. One such example is Configuration.substituteVars() and
> TaskLog.getBaseLogDir().
> substituteVars() shows the issue when the getProperty returns empty String,
> skipping the getRaw(var) expression. One way to work around this could be
> {code}
> if (val == null || val.isEmpty()) {
> String raw = getRaw(var);
> if (raw != null) {
> // raw contains a value, otherwise default to whatever
> System.getProperty returned
> // since it could be an empty string
> val = raw;
> }
> }
> {code}
> getBaseLogDir, similarly when returns an empty string the schematics of
> java.io.File differs dependent on whether parent is null or "". A null value
> is interpreted as new File(file); whereas "" will be interpreted as new
> File(defaultParent /* / */, file);
> This could simply be addressed with
> {code}
> static String getBaseLogDir() {
> String logDir = System.getProperty("hadoop.log.dir");
> // there is a difference how null and "" is treated as a parent
> // directory when creating a file
> return logDir == null || logDir.isEmpty() ? null : logDir;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
