[
https://issues.apache.org/jira/browse/MAPREDUCE-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729241#comment-14729241
]
Chang Li commented on MAPREDUCE-6442:
-------------------------------------
Hi [~ozawa], thanks for review. But usually log based change doesn't need a
unit test. Also for my change
{code}
catch (Exception e) {
LOG.info("Failed to use " + provider.getClass().getName()
+ " due to error: ", e);
}
{code}
that exception is caught, and error message merely gets logged. The exception
is not thrown. Do you have any recommendation how to test that in a unit test?
Moreover, I have manually test this change. I verified that the stack trace is
printed and I post the stack trace in the above comment.
> Stack trace missing for client protocol provider creation error
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-6442
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6442
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Reporter: Chang Li
> Assignee: Chang Li
> Attachments: MAPREDUCE-6442.2.patch, MAPREDUCE-6442.patch
>
>
> when provider creation fail dump the stack trace rather than just print out
> the message
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
