[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743205#comment-14743205
 ] 

Steve Loughran commented on MAPREDUCE-6462:
-------------------------------------------

-1 —due to test assumptions

# {{TestApplicationHistoryServer}} failing as # of child services is 6, not 5
# same for {{TestJobHistoryServer}}

Two fixes come to mind
# increase the count, while adding an explanation message "child service count" 
to the asserts
# cull the check altogether. Why do the tests need to validate the no. of 
children. It's too brittle and delivers no apparent benefit.

> JobHistoryServer to support JvmPauseMonitor as a service
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-6462
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6462
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: jobhistoryserver
>    Affects Versions: 2.8.0
>            Reporter: Sunil G
>            Assignee: Sunil G
>            Priority: Minor
>         Attachments: 0001-MAPREDUCE-6462.patch, HADOOP-12321-003.patch
>
>
> As JvmPauseMonitor is made as an AbstractService, subsequent method changes 
> are needed in all places which uses the monitor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to