[
https://issues.apache.org/jira/browse/MAPREDUCE-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906522#comment-14906522
]
Jason Lowe commented on MAPREDUCE-6491:
---------------------------------------
bq. sorry this took so long, I got sidetracked with other projects!
No worries, I know all too well how that goes.
Thanks for updating the patch. It looks good overall with just a few nits left.
The javadoc for the new Configuration method mentions that it will return an
empty Collection as a default then later says it returns the specified default
value.
MRApps had several redundant imports added to it, and we should import
java.util.Collection directly rather than java.util.* to get it.
> Environment variable handling assumes values should be appended
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-6491
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6491
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.2.0
> Reporter: Jason Lowe
> Assignee: Dustin Cote
> Attachments: YARN-2369-1.patch, YARN-2369-2.patch, YARN-2369-3.patch,
> YARN-2369-4.patch, YARN-2369-5.patch, YARN-2369-6.patch, YARN-2369-7.patch
>
>
> When processing environment variables for a container context the code
> assumes that the value should be appended to any pre-existing value in the
> environment. This may be desired behavior for handling path-like environment
> variables such as PATH, LD_LIBRARY_PATH, CLASSPATH, etc. but it is a
> non-intuitive and harmful way to handle any variable that does not have
> path-like semantics.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
