[
https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940240#comment-14940240
]
Hadoop QA commented on MAPREDUCE-5747:
--------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 16m 31s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 8m 0s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 17s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 0m 15s | The applied patch generated
1 release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 26s | The applied patch generated 1
new checkstyle issues (total was 10, now 10). |
| {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 37s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 52s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | mapreduce tests | 5m 58s | Tests passed in
hadoop-mapreduce-client-hs. |
| | | 44m 34s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12764651/MAPREDUCE-5747-7.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / ecbfd68 |
| Release Audit |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6048/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6048/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt
|
| hadoop-mapreduce-client-hs test log |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6048/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6048/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6048/console |
This message was automatically generated.
> Potential null pointer deference in HsTasksBlock#render()
> ---------------------------------------------------------
>
> Key: MAPREDUCE-5747
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
> Labels: BB2015-05-TBR, newbie, patch
> Attachments: MAPREDUCE-5747-1.patch, MAPREDUCE-5747-2.patch,
> MAPREDUCE-5747-3.patch, MAPREDUCE-5747-4.patch, MAPREDUCE-5747-5.patch,
> MAPREDUCE-5747-6.patch, MAPREDUCE-5747-7.patch
>
>
> At line 140:
> {code}
> } else {
> ta = new TaskAttemptInfo(successful, type, false);
> {code}
> There is no check for type against null.
> TaskAttemptInfo ctor deferences type:
> {code}
> public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
> final TaskAttemptReport report = ta.getReport();
> this.type = type.toString();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
