[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045030#comment-15045030
]
Daniel Templeton commented on MAPREDUCE-6542:
---------------------------------------------
Nicely done, [~piaoyu zhang]. The last four things I see are:
* The private {{getFormattedTimeWithDiff()}} method needs javadocs
* You may as well make the two catches in the test method into one multi-catch
(http://docs.oracle.com/javase/8/docs/technotes/guides/language/catch-multiple.html).
* The comments inside the catch blocks in the tests say "expected." The
exceptions aren't really expected; we just don't mind if they happen.
"Ignored," might be a better comment. I said it earlier, but it bears
repeating: this would be very bad coding style in production code. It's only
acceptable here because it's test code where we can legitimately not care about
those exceptions. Maybe a better comment would be to explain that since you're
doing the operation many times, you can ignore the exception this time and hope
it succeeds next time.
* You need to {{awaitTermination()}} after shutting down the
{{ExecutorService}}.
Almost there. :)
> HistoryViewer use SimpleDateFormat,But SimpleDateFormat is not threadsafe
> -------------------------------------------------------------------------
>
> Key: MAPREDUCE-6542
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6542
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobhistoryserver
> Affects Versions: 2.2.0, 2.7.1
> Environment: CentOS6.5 Hadoop
> Reporter: zhangyubiao
> Assignee: zhangyubiao
> Attachments: MAPREDUCE-6542-v2.patch, MAPREDUCE-6542-v3.patch,
> MAPREDUCE-6542-v4.patch, MAPREDUCE-6542-v5.patch, MAPREDUCE-6542-v6.patch,
> MAPREDUCE-6542-v7.patch, MAPREDUCE-6542.patch
>
>
> I use SimpleDateFormat to Parse the JobHistory File before
> {code}
> private static final SimpleDateFormat dateFormat =
> new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
> public static String getJobDetail(JobInfo job) {
> StringBuffer jobDetails = new StringBuffer("");
> SummarizedJob ts = new SummarizedJob(job);
> jobDetails.append(job.getJobId().toString().trim()).append("\t");
> jobDetails.append(job.getUsername()).append("\t");
> jobDetails.append(job.getJobname().replaceAll("\\n",
> "")).append("\t");
> jobDetails.append(job.getJobQueueName()).append("\t");
> jobDetails.append(job.getPriority()).append("\t");
> jobDetails.append(job.getJobConfPath()).append("\t");
> jobDetails.append(job.getUberized()).append("\t");
>
> jobDetails.append(dateFormat.format(job.getSubmitTime())).append("\t");
>
> jobDetails.append(dateFormat.format(job.getLaunchTime())).append("\t");
>
> jobDetails.append(dateFormat.format(job.getFinishTime())).append("\t");
> return jobDetails.toString();
> }
> {code}
> But I find I query the SubmitTime and LaunchTime in hive and compare
> JobHistory File time , I find that the submitTime and launchTime was wrong.
> Finally,I change to use the FastDateFormat to parse the time format and the
> time become right
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
