[
https://issues.apache.org/jira/browse/MAPREDUCE-6616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121505#comment-15121505
]
Akira AJISAKA commented on MAPREDUCE-6616:
------------------------------------------
Thanks [~sarutak] for creating the patch. Mostly looks good to me. Minor nits:
1.
{code}
// amount size of first 5 characters < 23
// 23 < amount size of first 6 characters
{code}
I'm thinking we should comment why the size is equal to 22, so the above
comment can be rewritten as follows:
{code}
// total size of the first 5 characters = 22
// 23 < total size of the first 6 characters
{code}
2.
{code}
import static java.nio.charset.StandardCharsets.UTF_8;
{code}
Would you remove unnecessary whitespace between "import" and "static"?
3.
{code}
//NumReduces
- sb.append(indexInfo.getNumReduces());
+ sb.append(encodeJobHistoryFileName(
+ String.valueOf(indexInfo.getNumReduces())));
sb.append(DELIMITER);
-
+
//JobStatus
- sb.append(indexInfo.getJobStatus());
+ sb.append(encodeJobHistoryFileName(indexInfo.getJobStatus()));
sb.append(DELIMITER);
-
+
//QueueName
- sb.append(escapeDelimiters(getQueueName(indexInfo)));
+ sb.append(escapeDelimiters(encodeJobHistoryFileName(
+ getQueueName(indexInfo))));
{code}
The patch includes mixed continuation indents (4 spaces and 8 spaces). Would
you make the indents consistent?
> Fail to create jobhistory file if there are some multibyte characters in the
> job name
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6616
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6616
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobhistoryserver
> Reporter: Akira AJISAKA
> Assignee: Kousuke Saruta
> Labels: i18n
> Attachments: MAPREDUCE-6616-test.patch, MAPREDUCE-6616.0.patch
>
>
> When creating jobhistory file, job name is trimmed within 50 characters by
> default, and the name is URL-encoded *after* the job name is trimmed.
> Therefore, if there are some multibyte characters in the job name, the
> encoded job name can be longer than 50 characters. Eventually it can break
> the limit of the file name (Usually 255 characters).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
