[
https://issues.apache.org/jira/browse/MAPREDUCE-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147010#comment-15147010
]
Akira AJISAKA commented on MAPREDUCE-6579:
------------------------------------------
Thanks [~Naganarasimha] for the detailed comment.
bq. IMO the modification in the testcase is fine but RMAppAttemptImpl
modifications are not required
Agree.
bq. whether we need to add additional check in {{NotRunningJob.getJobReport}}
I'm okay to add the additional check for compatibility, but it is not enough.
I'm thinking there are some possibility to add diagnostic message (such as task
failure) even if the job is running. In this case, the following check is
needed.
{code}
public synchronized String getFailureInfo() {
- return this.failureInfo;
+ if (runState == State.FAILED || runState == State.KILLED) {
+ return this.failureInfo;
+ }
+ return "";
}
{code}
> JobStatus#getFailureInfo should not output diagnostic information when the
> job is running
> -----------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6579
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6579
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Reporter: Rohith Sharma K S
> Assignee: Akira AJISAKA
> Priority: Blocker
> Attachments: MAPREDUCE-6579.01.patch, MAPREDUCE-6579.02.patch,
> MAPREDUCE-6579.03.patch, MAPREDUCE-6579.04.patch, MAPREDUCE-6579.05.patch,
> MAPREDUCE-6579.06.patch
>
>
> From
> [https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt]
> TestNetworkedJob are failed intermittently.
> {code}
> Running org.apache.hadoop.mapred.TestNetworkedJob
> Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 81.131 sec
> <<< FAILURE! - in org.apache.hadoop.mapred.TestNetworkedJob
> testNetworkedJob(org.apache.hadoop.mapred.TestNetworkedJob) Time elapsed:
> 30.55 sec <<< FAILURE!
> org.junit.ComparisonFailure: expected:<[[Tue Dec 15 14:02:45 +0000 2015]
> Application is Activated, waiting for resources to be assigned for AM.
> Details : AM Partition = <DEFAULT_PARTITION> ; Partition Resource =
> <memory:8192, vCores:16> ; Queue's Absolute capacity = 100.0 % ; Queue's
> Absolute used capacity = 0.0 % ; Queue's Absolute max capacity = 100.0 % ; ]>
> but was:<[]>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.hadoop.mapred.TestNetworkedJob.testNetworkedJob(TestNetworkedJob.java:174)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
