[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215800#comment-15215800
 ] 

Akira AJISAKA commented on MAPREDUCE-6663:
------------------------------------------

Thanks Brahma for updating the patch!
{code}
+      throw new HadoopIllegalArgumentException(
+          "Error: Block Size in bytes must be a multiple of \" +\n"
+              + "              \"bytes per checksum:");
{code}
1. Would you remove unnecessarily whitespaces and {{\n}} in the error message?
2. Would you remove trailing whitespace?

> [ NN Bench ] Refactor nnbench as a Tool implementation.
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-6663
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6663
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HDFS-7651-001.patch, HDFS-7651-002.patch, 
> HDFS-7651-003.patch, HDFS-7651-004.patch
>
>
> {code}
> public class NNBench {
>   private static final Log LOG = LogFactory.getLog(
>           "org.apache.hadoop.hdfs.NNBench");
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to