[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256699#comment-15256699
]
Daniel Templeton commented on MAPREDUCE-6657:
---------------------------------------------
Looks good, [~haibochen]. One thing I just noticed, though, is that you need
to update the comment on {{HistoryFileManager.isBecauseSafeMode()}} to reflect
the new behavior. You might consider renaming the method as well, since the
name is also no longer exactly accurate.
> job history server can fail on startup when NameNode is in start phase
> ----------------------------------------------------------------------
>
> Key: MAPREDUCE-6657
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6657
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobhistoryserver
> Reporter: Haibo Chen
> Assignee: Haibo Chen
> Attachments: mapreduce6657.001.patch, mapreduce6657.002.patch,
> mapreduce6657.003.patch, mapreduce6657.004.patch
>
>
> Job history server will try to create a history directory in HDFS on startup.
> When NameNode is in safe mode, it will keep retrying for a configurable time
> period. However, it should also keeps retrying if the name node is in start
> state. Safe mode does not happen until the NN is out of the startup phase.
> A RetriableException with the text "NameNode still not started" is thrown
> when the NN is in its internal service startup phase. We should add the check
> for this specific exception in isBecauseSafeMode() to account for that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
