[
https://issues.apache.org/jira/browse/MAPREDUCE-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263116#comment-15263116
]
Sangjin Lee commented on MAPREDUCE-6424:
----------------------------------------
(JobHistoryEventHandler.java)
- l.1053: I believe this causes a checkstyle violation (line too long)
- l.1054: {{timestamp}} here is no longer used, and should be removed
(JobFinishedEvent.java)
- l.161: Sorry I should have been clearer, but since we have a clear timestamp
associated with this event ({{finishTime}}), I think we ought to use that time
over the current time millis. Thoughts? Same for {{MapAttemptFinishedEvent}},
{{ReduceAttemptFinishedEvent}}, {{TaskAttemptFinishedEvent}},
{{TaskAttemptUnsuccessfulCompletionEvent}}, {{TaskFailedEvent}}, and
{{TaskFinishedEvent}}
(TestMRTimelineEventHandling.java)
- l.337-359: Is it possible to use {{GenericTestUtils.waitFor()}} for this?
> Store MR counters as timeline metrics instead of event
> ------------------------------------------------------
>
> Key: MAPREDUCE-6424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6424
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Junping Du
> Assignee: Naganarasimha G R
> Labels: yarn-2928-1st-milestone
> Attachments: MAPREDUCE-6424-YARN-2928.v1.001.patch,
> MAPREDUCE-6424-YARN-2928.v1.002.patch, MAPREDUCE-6424-YARN-2928.v1.003.patch
>
>
> In MAPREDUCE-6327, we make map/reduce counters get encoded from
> JobFinishedEvent as timeline events with counters details in JSON format.
> We need to store framework specific counters as metrics in timeline service
> to support query, aggregation, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
