[
https://issues.apache.org/jira/browse/MAPREDUCE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289975#comment-15289975
]
Eric Payne commented on MAPREDUCE-5044:
---------------------------------------
[~mingma], thank you very much for the comments. I have one question:
{quote}
- ... it might be useful to rename signalContainer to signalContainers so that
we don't need to modify the API later, which means some new structure like
SignalContainersRequest. What is your take?
{quote}
I would rather not rename {{signalContainer}} to {{signalContainers}} because
{{signalContainers}} sounds to me like the purpose is to send one signal to
multiple containers rather than to send multiple signals to one container.
Calling it {{signalsContainer}} (plural {{signals}}) also sounds awkward. So, I
think {{signalContainer}} is the best option.
Regarding {{SignalContainerRequest}}, if we want the {{signalContainer}} API to
be fully compatible with sending multiple signals, I think
{{SignalContainerRequest}} would need to add an interface for
{{SignalContainerRequest#newInstance}} that included both pause and a list of
signals. Maybe something like this:
{code}
public static SignalContainerRequest newInstance(ContainerId containerId,
int pause, Iterable<SignalContainerCommand> signals) {
...
}
{code}
I think it would be best to add that interface to {{SignalContainerRequest}} in
the future when we are ready to implement the rest of the "sending multiple
signals" feature. Thoughts?
> Have AM trigger jstack on task attempts that timeout before killing them
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-5044
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5044
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mr-am
> Affects Versions: 2.1.0-beta
> Reporter: Jason Lowe
> Assignee: Gera Shegalov
> Attachments: MAPREDUCE-5044.008.patch, MAPREDUCE-5044.009.patch,
> MAPREDUCE-5044.v01.patch, MAPREDUCE-5044.v02.patch, MAPREDUCE-5044.v03.patch,
> MAPREDUCE-5044.v04.patch, MAPREDUCE-5044.v05.patch, MAPREDUCE-5044.v06.patch,
> MAPREDUCE-5044.v07.local.patch, Screen Shot 2013-11-12 at 1.05.32 PM.png,
> Screen Shot 2013-11-12 at 1.06.04 PM.png
>
>
> When an AM expires a task attempt it would be nice if it triggered a jstack
> output via SIGQUIT before killing the task attempt. This would be invaluable
> for helping users debug their hung tasks, especially if they do not have
> shell access to the nodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
