[
https://issues.apache.org/jira/browse/MAPREDUCE-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328238#comment-15328238
]
Li Lu commented on MAPREDUCE-6380:
----------------------------------
Thanks for the patch [~lewuathe]! One small concern here:
l.87, AggregatedLogDeletionService.java,
bq. if (fs.listStatus(userDirPath).length != 0) {
Seems like we're only checking if the directory is empty, but filled all file
status objects in this directory. Maybe we'd like to use something like
listStatusIterator and then check if the iterator has next? In this way we do
not need to fill in the file status.
> AggregatedLogDeletionService will throw exception when there are some other
> directories in remote-log-dir
> ---------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6380
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6380
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobhistoryserver
> Reporter: Zhang Wei
> Assignee: Kai Sasaki
> Priority: Trivial
> Attachments: MAPREDUCE-6380.01.patch, MAPREDUCE-6380.02.patch,
> MAPREDUCE-6380.03.patch
>
>
> AggregatedLogDeletionService will throw FileNotFoundException when there are
> some extraneous directories put in remote-log-dir. The deletion function will
> try to listStatus against the "extraneous-dir + suffix" dir. I think it
> would be better if the function can ignore these directories.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
