[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348912#comment-15348912
 ] 

Haibo Chen commented on MAPREDUCE-6625:
---------------------------------------

Thanks Jason for pointing out the other issue as well. We could just remove the 
second assert as it may not be meaningful.  But it seems to me that checking if 
retry inside CLI.getJob() works by measuring time elapsed because of sleep is 
not generally a robust solution. Instead, we can just rely on the return value. 
Attaching a patch that checks return value to see if retry works.

> TestCLI#testGetJob fails occasionally
> -------------------------------------
>
>                 Key: MAPREDUCE-6625
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6625
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Jason Lowe
>            Assignee: Haibo Chen
>         Attachments: mapreduce6625.001.patch
>
>
> Lately TestCLI has been failing sometimes in precommit builds:
> {noformat}
> Running org.apache.hadoop.mapreduce.tools.TestCLI
> Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.883 sec <<< 
> FAILURE! - in org.apache.hadoop.mapreduce.tools.TestCLI
> testGetJob(org.apache.hadoop.mapreduce.tools.TestCLI)  Time elapsed: 0.037 
> sec  <<< FAILURE!
> java.lang.AssertionError: null
>       at org.junit.Assert.fail(Assert.java:86)
>       at org.junit.Assert.assertTrue(Assert.java:41)
>       at org.junit.Assert.assertTrue(Assert.java:52)
>       at 
> org.apache.hadoop.mapreduce.tools.TestCLI.testGetJob(TestCLI.java:175)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to