Jason Lowe commented on MAPREDUCE-6771:

Thanks for updating the patch!

Rather than having the test reach into what is essentially a private function, 
processFinishedContainer, I think we can test this as a black-box.  By 
providing a mocked event handler in the AppContext we can see what events are 
sent to it for order verification, and we can use Mockito InOrder verification 
to verify the order of events rather than having to manually capture them.  
Then we can write a test like the others using MockScheduler to test this 
without reaching into the internals of RMContainerAllocator.

If you decide that's not worth it, processFinishedContainer should not be 
public but rather package-private which removes the need to mark it with the 
Private annotation.

testHandleingFinishedContainers s/b testHandlingFinishedContainers

> RMContainerAllocator sends container diagnostics event after corresponding 
> completion event
> -------------------------------------------------------------------------------------------
>                 Key: MAPREDUCE-6771
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6771
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 2.7.3
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>         Attachments: TaUnsuccessfullyEventEmission.jpg, 
> mapreduce6771.001.patch, mapreduce6771.002.patch, mapreduce6771.003.patch
> Task containers can go over their resource limit, and killed by Node Manager. 
> Then MR AM gets notified of the container status and diagnostics information 
> through its heartbeat with RM.  However, it is possible that the diagnostics 
> information never gets into .jhist file, so when the job completes, the 
> diagnostics information associated with the failed task attempts is empty.  
> This makes it hard for users to root cause job failures that are often caused 
> by memory leak.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to