[
https://issues.apache.org/jira/browse/MAPREDUCE-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654958#comment-15654958
]
Gera Shegalov commented on MAPREDUCE-6793:
------------------------------------------
the checkstyle warnings don't seem to be worth fixing.
bq.
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/MapTask.java:1824:
private void mergeParts() throws IOException, InterruptedException, :5:
Method length is 151 lines (max allowed is 150).
Either this or the line width violation :)
bq.
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java:218:
public static final int DEFAULT_IO_SORT_FACTOR = 10;:3: Redundant 'public'
modifier.
bq.
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java:222:
public static final int DEFAULT_IO_SORT_MB = 100;:3: Redundant 'public'
modifier.
The 2 above are for consistency with the rest of MRJobConfig. We can clean up
'public static final' for all fields in a separate JIRA
> io.sort.factor code default and mapred-default.xml values inconsistent
> ----------------------------------------------------------------------
>
> Key: MAPREDUCE-6793
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6793
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: task
> Affects Versions: 2.6.5, 3.0.0-alpha1
> Reporter: Gera Shegalov
> Assignee: Prabhu Joseph
> Priority: Trivial
> Labels: noob
> Attachments: 0001-MAPREDUCE-6793.patch, 0002-MAPREDUCE-6793.patch,
> MAPREDUCE-6793.003.patch
>
>
> The actual default value in mapred-default.xml:
> {code}
> <property>
> <name>mapreduce.task.io.sort.factor</name>
> <value>10</value>
> <description>The number of streams to merge at once while sorting
> files. This determines the number of open file handles.</description>
> </property>
> {code}
> However, MapTask and MergeManagerImpl, are coded with:
> {code}
> int mergeFactor = job.getInt(JobContext.IO_SORT_FACTOR, 100);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
