[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658033#comment-15658033
 ] 

Naganarasimha G R commented on MAPREDUCE-6809:
----------------------------------------------

Hi [~devaraj.k],
I think we are almost there, just for few clarifications or corrections :
# As part of this activity do we require to define {{ContainerAvailableEvent}} 
? IIUC this is mainly required for the newly class 
{{RMContainerReuseRequestor}} which will be extending {{ContainerRequestor}} 
(as part of YARN-6773). So think no need to introduce this class and hence also 
remove  extends {{EventHandler<ContainerAvailableEvent>}} in ContainerRequestor 
interface
# {{ContainerRequestor.EventType}}, IIUC is again used by only 
RMContainerReuseRequestor and hence we can segregate it and handle in 
MAPREDUCE-6773 itself.

By doing the above two it would be purely extracting out the interface from the 
existing code which is what we wanted achieve in this patch ! 

> Create ContainerRequestor interface and refactor RMContainerRequestor to use 
> it
> -------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6809
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6809
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: applicationmaster, mrv2
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>         Attachments: MAPREDUCE-6809-MR-6749.001.patch
>
>
> As per the discussion in MAPREDUCE-6773, create a ContainerRequestor 
> interface and refactor RMContainerRequestor to use this interface.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to