[
https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802758#comment-15802758
]
Daniel Templeton commented on MAPREDUCE-6715:
---------------------------------------------
That part looks fine to me. I'm looking more closely at the
{{ShuffleSchedulerImpl}} changes now. First, throwing {{InterruptedException}}
in the wrong thing to do. Second, the analyzer is wrong--{{host}} can't be
null. Maybe if you rearrange the code like this: {code} Iterator<MapHost>
iter = pendingHosts.iterator();
// Safe to take one because we know pendingHosts isn't empty
host = iter.next();
int numToPick = random.nextInt(pendingHosts.size());
for (int i=0; i < numToPick; ++i) {
host = iter.next();
}{code} the analyzer would be happier?
> Fix Bad Practices
> -----------------
>
> Key: MAPREDUCE-6715
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6715
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.9.0
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Attachments: MAPREDUCE-6715.001.patch, MAPREDUCE-6715.002.patch,
> MAPREDUCE-6715.003.patch, MAPREDUCE-6715.004.patch, MAPREDUCE-6715.005.patch
>
>
> {code}
> Null Dereference CleanupQueue.java:139
> Weak SecurityManager Check: Overridable Method
> LocalDistributedCacheManager.java:229
> Null Dereference TextOutputFormat.java:137
> Null Dereference ShuffleSchedulerImpl.java:422
> Null Dereference MapTask.java:415
> Null Dereference Pentomino.java:160
> Unreleased Resource: Streams TeraScheduler.java:77
> Unreleased Resource: Streams CLI.java:570
> Null Dereference CLI.java:370
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
