[
https://issues.apache.org/jira/browse/MAPREDUCE-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838494#comment-15838494
]
Karthik Kambatla commented on MAPREDUCE-6829:
---------------------------------------------
The patch looks good, but for the following nits:
# Can we import Mapper and Reducer so the definition of classes TokenizerMapper
and IntSumReducer can fit in two lines, may be split the line after extends?
# TokenizerMapper#map method indentation looks funny. How about the following:
{code}
public void map(Object key, Text value, Context context)
throws IOException, InterruptedException {
{code}
# IntSumReducer#reduce method indentation looks funny. How about the following:
{code}
public void reduce(Text key, Iterable<IntWritable> values, Context context)
throws IOException, InterruptedException {
{code}
# The InternalClass seems unnecessary. If the intent is just to be able to
identify the caller jar, why not just use this.getClass()?
> Add peak memory usage counter for each task
> -------------------------------------------
>
> Key: MAPREDUCE-6829
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6829
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Reporter: Yufei Gu
> Assignee: Miklos Szegedi
> Attachments: MAPREDUCE-6829.000.patch, MAPREDUCE-6829.001.patch,
> MAPREDUCE-6829.002.patch, MAPREDUCE-6829.003.patch, MAPREDUCE-6829.004.patch
>
>
> Each task has counters PHYSICAL_MEMORY_BYTES and VIRTUAL_MEMORY_BYTES, which
> are snapshots of memory usage of that task. They are not sufficient for users
> to understand peak memory usage by that task, e.g. in order to diagnose task
> failures, tune job parameters or change application design. This new feature
> will add two more counters for each task: PHYSICAL_MEMORY_BYTES_MAX and
> VIRTUAL_MEMORY_BYTES_MAX.
> This JIRA has the same feature from MAPREDUCE-4710. I file this new YARN
> JIRA since MAPREDUCE-4710 is pretty old one from MR 1.x era, it more or less
> assumes a branch-1 architecture, should be close at this point.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
