[
https://issues.apache.org/jira/browse/MAPREDUCE-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061492#comment-16061492
]
Ray Chiang commented on MAPREDUCE-6901:
---------------------------------------
I'm still not done yet, but a couple of observations.
1. I see two files in the hadoop-mapreduce-client-core module:
{noformat}
org/apache/hadoop/filecache/DistributedCache.java
org/apache/hadoop/mapreduce/filecache/DistributedCache.java
{noformat}
with the former extending the latter. I don't see the former being used much
2. It looks like the original @deprecation tags were added with MAPREDUCE-898,
where the methods were moved from DistributedCache to JobContextImpl/JobImpl
(talking about the code, not just the interfaces).
Solutions-wise:
A) Structurally, I don't see a good way to refactor it due to DistributedCache
methods being static and JobContext methods not being static.
B) There is the backwards compatibility issue mentioned by [~jlowe].
C) The DeprecatedCache has been relatively easy to support (7 changes or so in
the past 6 years according to git).
Given the above, I can see only a minor bit of cleanup:
i) Is there a reason to *keep* the @deprecated tag?
ii) There's the same javadoc header in the two DistributedCache files. I think
I'd prefer to have one class with the javadoc and the other file point to the
other class's javadoc.
> Remove DistributedCache from trunk
> ----------------------------------
>
> Key: MAPREDUCE-6901
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6901
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: distributed-cache
> Affects Versions: 3.0.0-alpha3
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Priority: Critical
>
> Doing this as part of Hadoop 3 cleanup.
> DistributedCache has been marked as deprecated forever to the point where the
> change that did it isn't in Git.
> I don't really have a preference for whether we remove it or not, but I'd
> like to have a discussion and have it properly documented as a release not
> for Hadoop 3 before we hit final release. At the very least we can have a
> Release Note that will sum up whatever discussion we have here.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
