[ https://issues.apache.org/jira/browse/MAPREDUCE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082925#comment-16082925 ]
Hadoop QA commented on MAPREDUCE-5621: -------------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 16m 37s{color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 12s{color} | {color:blue} Shelldocs was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 9m 16s{color} | {color:red} root in branch-2 failed. {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 45s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 39s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 8s{color} | {color:red} The patch generated 2 new + 502 unchanged - 2 fixed = 504 total (was 504) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 18s{color} | {color:green} hadoop-mapreduce-project in the patch passed with JDK v1.7.0_131. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 32m 28s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:5e40efe | | JIRA Issue | MAPREDUCE-5621 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12876672/MAPREDUCE-5621-branch-2.patch | | Optional Tests | asflicense mvnsite unit shellcheck shelldocs | | uname | Linux cb67c9726cf6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | branch-2 / e494a16 | | mvninstall | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7023/artifact/patchprocess/branch-mvninstall-root.txt | | shellcheck | v0.4.6 | | shellcheck | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7023/artifact/patchprocess/diff-patch-shellcheck.txt | | JDK v1.7.0_131 Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7023/testReport/ | | modules | C: hadoop-mapreduce-project U: hadoop-mapreduce-project | | Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7023/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > mr-jobhistory-daemon.sh doesn't have to execute mkdir and chown all the time > ---------------------------------------------------------------------------- > > Key: MAPREDUCE-5621 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5621 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: jobhistoryserver > Affects Versions: 2.8.0 > Reporter: Shinichi Yamashita > Assignee: Shinichi Yamashita > Priority: Minor > Labels: BB2015-05-TBR > Attachments: MAPREDUCE-5621-branch-2.patch, MAPREDUCE-5621.patch > > > mr-jobhistory-daemon.sh executes mkdir and chown command to output the log > files. > This is always executed with or without a directory. In addition, this is > executed not only starting daemon but also stopping daemon. > It add "if" like hadoop-daemon.sh and yarn-daemon.sh and should control it. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org