[
https://issues.apache.org/jira/browse/MAPREDUCE-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111744#comment-16111744
]
Jason Lowe commented on MAPREDUCE-6927:
---------------------------------------
Thanks for the report and patch! It would be helpful if you elaborated a bit
more in the JIRA description about the problem this is fixing and how it
manifests in practice.
I think we should set the tracking URL as soon as the .jhist file is
successfully put in the done folder which is a bit earlier than where it is now
in the patch. Even if we fail to get the conf to done, there should be some
MapReduce-specific history once the .jhist file is there. Also as written in
the patch, there could be a case where we "successfully" complete
processDoneFiles but nothing was actually placed in the done directory (i.e.:
for whatever reason mi.getHistoryFile() == null).
It would be nice if the unit test verified the job history URL was correctly
rather than just any string at all. I think the test should also verify that
even if the job history event handler receives a job finished event but is
unable to complete moving the history to the done directory that it does not
set the tracking URL.
> MR job should only set tracking url if history was successfully written
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-6927
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6927
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Eric Badger
> Assignee: Eric Badger
> Attachments: MAPREDUCE-6927.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
