[
https://issues.apache.org/jira/browse/MAPREDUCE-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Badger updated MAPREDUCE-6927:
-----------------------------------
Attachment: MAPREDUCE-6927.002.patch
[~jlowe], thanks for the comments. I'm not quite sure why I didn't write a
description. I'll fix that.
{quote}
I think we should set the tracking URL as soon as the .jhist file is
successfully put in the done folder which is a bit earlier than where it is now
in the patch.
{quote}
I moved the {{setHistoryFile()}} call up to just after the .jhist file is moved
to done.
bq. It would be nice if the unit test verified the job history URL was
correctly rather than just any string at all.
Fixed
bq. I think the test should also verify that even if the job history event
handler receives a job finished event but is unable to complete moving the
history to the done directory that it does not set the tracking URL.
I had to mock up more stuff than I wanted to to get this to work. Let me know
if you have a better way in mind that can accomplish the same thing.
> MR job should only set tracking url if history was successfully written
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-6927
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6927
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Eric Badger
> Assignee: Eric Badger
> Attachments: MAPREDUCE-6927.001.patch, MAPREDUCE-6927.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
