[
https://issues.apache.org/jira/browse/MAPREDUCE-6838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131811#comment-16131811
]
Rohith Sharma K S commented on MAPREDUCE-6838:
----------------------------------------------
thanks [~varun_saxena] for the patch. It seems patch do not apply, required to
rebase.
# Why are changing hadoop-common code to ignore ignoreUseIpConfig? Is this
because to add test case? Does test is failing?
# I just noticed that TimelineDelegationTokenIdentifier#Renewer has methods
renew/cancel. These creates V1 client. Does it going to be a problem?
# I think it is better to update token on each heart beat rather then comparing
each time. It avoids proto compare.
# This appears mixing collectorManager i.e NMCollectorService authentication
and MR side. Is both required here or can we raise new JIRA? Was it conflicting
with MR publisher ? One thing I observe is TimelineClient is published using
login user which is doAS. I think we should publish is as owner of application
otherwise we end up in writing data into sub app application table as well.
> [ATSv2 Security] Add timeline delegation token received in allocate response
> to UGI
> -----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6838
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6838
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: yarn-5355-merge-blocker
> Fix For: YARN-5355
>
> Attachments: MAPREDUCE-6838-YARN-5355.01.patch,
> MAPREDUCE-6838-YARN-5355.02.patch, MAPREDUCE-6838-YARN-5355.03.patch,
> MAPREDUCE-6838-YARN-5355.03.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
