[
https://issues.apache.org/jira/browse/MAPREDUCE-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170696#comment-16170696
]
Jason Lowe commented on MAPREDUCE-6491:
---------------------------------------
Thanks for the review, Allen!
bq. DYLD_LIBRARY_PATH should be in the list
Ah, good catch. Should it also include other dynamic linker related variables
like the following?
DYLD_FALLBACK_LIBRARY_PATH
DYLD_VERSIONED_LIBRARY_PATH
DYLD_FRAMEWORK_PATH
DYLD_FALLBACK_FRAMEWORK_PATH
DYLD_VERSIONED_FRAMEWORK_PATH
LD_RUN_PATH
bq. As mentioned several times, this won't work if a job (e.g., streaming)
calls the shell scripts with the default values.
Is this any different that what will happen without this patch? If
HADOOP_CLASSPATH shouldn't be appended to in trunk but the code _always_
appends new values to environment variables, then this seems like it's already
broken whether this is fixed or not. My apologies if I'm missing something.
> Environment variable handling assumes values should be appended
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-6491
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6491
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.2.0
> Reporter: Jason Lowe
> Assignee: Dustin Cote
> Attachments: MAPREDUCE-6491.011.patch, YARN-2369-10.patch,
> YARN-2369-1.patch, YARN-2369-2.patch, YARN-2369-3.patch, YARN-2369-4.patch,
> YARN-2369-5.patch, YARN-2369-6.patch, YARN-2369-7.patch, YARN-2369-8.patch,
> YARN-2369-9.patch
>
>
> When processing environment variables for a container context the code
> assumes that the value should be appended to any pre-existing value in the
> environment. This may be desired behavior for handling path-like environment
> variables such as PATH, LD_LIBRARY_PATH, CLASSPATH, etc. but it is a
> non-intuitive and harmful way to handle any variable that does not have
> path-like semantics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
