[
https://issues.apache.org/jira/browse/MAPREDUCE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216808#comment-16216808
]
Hadoop QA commented on MAPREDUCE-6296:
--------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
47s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
25s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
46s{color} | {color:green} hadoop-mapreduce-client-core in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:ca8ddc6 |
| JIRA Issue | MAPREDUCE-6296 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12708102/MAPREDUCE-6296.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 291dacfd0c87 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / b90750c |
| Default Java | 1.8.0_131 |
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7204/testReport/ |
| modules | C:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
U:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7204/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> A better way to deal with InterruptedException on waitForCompletion
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-6296
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6296
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Yang Hao
> Assignee: Yang Hao
> Labels: BB2015-05-TBR
> Attachments: MAPREDUCE-6296.patch
>
>
> Some code in method waitForCompletion of Job class is
> {code:title=Job.java|borderStyle=solid}
> public boolean waitForCompletion(boolean verbose
> ) throws IOException, InterruptedException,
> ClassNotFoundException {
> if (state == JobState.DEFINE) {
> submit();
> }
> if (verbose) {
> monitorAndPrintJob();
> } else {
> // get the completion poll interval from the client.
> int completionPollIntervalMillis =
> Job.getCompletionPollInterval(cluster.getConf());
> while (!isComplete()) {
> try {
> Thread.sleep(completionPollIntervalMillis);
> } catch (InterruptedException ie) {
> }
> }
> }
> return isSuccessful();
> }
> {code}
> but a better way to deal with InterruptException is
> {code:title=Job.java|borderStyle=solid}
> public boolean waitForCompletion(boolean verbose
> ) throws IOException, InterruptedException,
> ClassNotFoundException {
> if (state == JobState.DEFINE) {
> submit();
> }
> if (verbose) {
> monitorAndPrintJob();
> } else {
> // get the completion poll interval from the client.
> int completionPollIntervalMillis =
> Job.getCompletionPollInterval(cluster.getConf());
> while (!isComplete()) {
> try {
> Thread.sleep(completionPollIntervalMillis);
> } catch (InterruptedException ie) {
> Thread.currentThread().interrupt();
> }
> }
> }
> return isSuccessful();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
