[
https://issues.apache.org/jira/browse/MAPREDUCE-7030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322725#comment-16322725
]
Robert Kanter commented on MAPREDUCE-7030:
------------------------------------------
The patch looks good. It doesn't look like it would be too hard to write unit
tests if you use the nio API like in the code. You can use
{{Files#createSymbolicLink}} to create symlinks. Adding a few symlinks to
{{TestFrameworkUploader#testCollectPackages}} to handle the different cases
would probably be enough.
> Uploader tool should ignore symlinks to the same directory
> ----------------------------------------------------------
>
> Key: MAPREDUCE-7030
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7030
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Miklos Szegedi
> Assignee: Miklos Szegedi
> Priority: Minor
> Attachments: MAPREDUCE-7030.000.patch, MAPREDUCE-7030.001.patch,
> MAPREDUCE-7030.002.patch, MAPREDUCE-7030.003.patch, MAPREDUCE-7030.004.patch,
> MAPREDUCE-7030.005.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
