[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328387#comment-16328387
 ] 

Akira Ajisaka commented on MAPREDUCE-7037:
------------------------------------------

Attached a sample patch.

I agree with Jason that creating OneFileInfo instance is required. However, I'm 
thinking the array itself is not needed.

> Possible dead code in CombineFileInputFormat
> --------------------------------------------
>
>                 Key: MAPREDUCE-7037
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7037
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Lior Regev
>            Priority: Minor
>              Labels: newbie
>         Attachments: MAPREDUCE-7037.001.patch
>
>
> I found that in the file:
> hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/CombineFileInputFormat.java:280
> There's a generation of OneFileInfo[] without using that array ever again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to